fix(dialog): use margin instead of padding for icon #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
How can I continue to make this PR after signed the CLA |
asyncLiz
approved these changes
Nov 13, 2023
asyncLiz
changed the title
Had to re-scan, looks good now! Thanks for the PR :) |
copybara-service
bot
merged commit 3e66c3e
into
material-components:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5182
The old version hide the md-icon in a md-dialog because of aggressive css rebooting of bootstrap.
My fix is to make the md-icon in md-dialog use margin-top instead of padding-top, and it fix the problem in my browser.
Thank to @christophe-g and @asyncLiz. They give me the opportunity to figure it out and to contribute this PR.